Improve dynamic pure loop cutting #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #584 should be fixed in this PR now. I don't know about issue #583. The new loop cutting is semantically equivalent to the old one (it detects the exact same sort of side effects). EDIT: |
|
I confirm both issues are solved now. I still need to review the code. |
Comment on lines
+86
to
+88
| // FIXME: The reasoning about safe/unsafe registers is not correct because | ||
| // we do not traverse the control-flow but naively go top-down through the loop. | ||
| // We need to use proper dominator reasoning! |
There was a problem hiding this comment.
We have this DominatorTree class, what else is needed to properly do this?
There was a problem hiding this comment.
Nothing but time :P. This code was always like this (i.e. not entirely correct).
Added simple DominatorAnalysis with static helper methods. Simplified DynamicPureLoopCutting using new dominator trees.
It now instruments the code without using ExecutionStatus.
into a single new pass: DynamicSpinLoopDetection. - Renamed OptionNames accordingly.
hernanponcedeleon
force-pushed
the
loopCutting
branch
from
136ca7d to
20342f9
Compare
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to improve
DynamicPureLoopCuttingin order to fix issues like #584and maybe let it detect different types of (conditional) side-effects.(Will be done in a different PR).I added a new general-purpose
DominatorTreeclass that can compute and represent dominator trees of graphs.This class might be useful for other program (or even wmm?) analyses.
DominatorTreeclass.DynamicPureLoopCuttingusingDominatorTree.DynamicPureLoopCuttingDynamicPureLoopCuttingandSimpleSpinLoopDetectioninto a single pass (the pass is namedDynamicSpinLoopDetection).