Wmm preprocessing #626
Merged
Wmm preprocessing #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessing. - Added new Wmm pass that merges equivalent relations
- Fixed ConstraintCopier to preserve axiom names when copying. - Fixed MergeEquivalentRelations to properly distinguish SameScope relations with different scopes.
- Fixed equality checking between SameScope definitions failing if their scopes were NULL
- Wmm.getOrCreatePredefinedRelation now creates new M*M / M*V relations when needed, relying on MergeEquivalentRelations to merge duplicates later on.
dartagnan/src/main/java/com/dat3m/dartagnan/wmm/processing/FlattenAssociatives.java
Show resolved
Hide resolved
dartagnan/src/main/java/com/dat3m/dartagnan/wmm/processing/MergeEquivalentRelations.java
Outdated
Show resolved
Hide resolved
dartagnan/src/main/java/com/dat3m/dartagnan/wmm/processing/RemoveDeadRelations.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks Wmm preprocessing to work similar to how program preprocessing works.
It further adds the following passes
RemoveDeadRelationswhich removes relations that do not contribute to axioms. This was already executed in the case of Refinement but now it runs also for the eager encoding although it shouldn't ever remove anything (though we could remove flagged axioms if we do not check for CAT properties which would create a lot of dead relations)MergeEquivalentRelationswhich attempts to find relations with equivalent relations, replacing them by a single representative. AFAIK, currently it only removes a singlerf^-1fromriscv-orig.catbecause it matches with anotherrf^-1that was implicitly created by parsingfr. EDIT: It also removes duplicates likeM*Mwhich are now created multiple times internally.