Fix time printing #630
Merged
Fix time printing #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed all printing of times to use Utils.toTimeString
# Conflicts: # dartagnan/src/main/java/com/dat3m/dartagnan/utils/Utils.java
| @@ -18,9 +18,9 @@ public static String toTimeString(long milliseconds) { | |||
| if (hours == 0 && minutes == 0) { | |||
| return String.format("%d.%d secs", seconds, milliseconds); | |||
| } else if (hours == 0) { | |||
| return String.format("%d:%d mins", minutes, seconds); | |||
| return String.format("%d:%02d mins", minutes, seconds); | |||
There was a problem hiding this comment.
Wouldn't it be better to use "%d mins %02d secs", minutes, seconds?
I personally find that format easier to read
There was a problem hiding this comment.
I like the other format better, but I can change it. In that case, you would also prefer %d hours, %02d mins, %02d secs? Seems kinda verbose to me
There was a problem hiding this comment.
I played around with a few more examples and I'm fine with the current format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.