Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special handling for hillshade and contour overlays #88

Open
3 tasks
hholzgra opened this issue Feb 26, 2023 · 1 comment
Open
3 tasks

Special handling for hillshade and contour overlays #88

hholzgra opened this issue Feb 26, 2023 · 1 comment

Comments

@hholzgra
Copy link
Owner

Most overlays want to have their data prominently on top, drawn over other features and so possibly replacing them.

Hillshade and contour layers are special in that they should be above certain layers (e.g. landuse fill patterns), but below others like e.g. POI markers; also some of the styles already come with their own such layers which should not be replaced, but potentially allowed to be turned off.

  • for styles that do have their own hillshade layers toggle style status
  • for styles without their own add overlay
  • in the long run merge hillshade/contour into loaded style after configurable layer name

This requires some special hard coded handling in the ocitysmap code, and also some configuration extensions, es.:

(hillshade_layers|contour_layers) = ... a list of one or more bundled layer names that can be turned on or off via the status property.
(hillshade_after|contour_after) ... a layer name after which hillshading or contour layers should be merged into the base style dynamically

@johsin18
Copy link

Would this fix the problem that hillshade makes the map very pale currently? This used to be different (a few years ago).
See here for example:
https://print.get-map.org/maps/330546/jcLQhSCAnAoKFpVf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants