refactor(react-server): use sync module for client/server reference #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi-ogawa
commented
Aug 31, 2024
Comment on lines
+17
to
+19
| // cache bust for each flight render during dev | ||
| // https://github.com/facebook/react/blob/ea6e05912aa43a0bbfbee381752caa1817a41a86/packages/react-server-dom-webpack/src/ReactFlightClientConfigBundlerWebpack.js#L182 | ||
| const cacheId = Math.random().toString(36).slice(2); |
There was a problem hiding this comment.
We might not need this since we already have "reference id" with ?t=... which should serve as an appropriate __webpack_chunk_load__ cache key?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on async module was definitely easier, but this might not be what React team wants to do in general. Rewriting to sync module (and thus removing one shaky patch) seems still simple but it relies on own cache busting for dev, which is not entirely cool.
todo