Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align semantics of insertAll() and friends with insertMultiple() and friends in ORM #2042

Closed
gavinking opened this issue Dec 19, 2024 · 2 comments · Fixed by #2053
Closed

align semantics of insertAll() and friends with insertMultiple() and friends in ORM #2042

gavinking opened this issue Dec 19, 2024 · 2 comments · Fixed by #2053
Labels
design A design or implementation issue enhancement New feature or request
Milestone
next

Comments

@gavinking
Copy link
Member

As of H6, ORM has operations like insertMultiple() accepting List<?> which implicitly set the batch size to the size of the given list. Reactive has very similar insertAll() operations, but they do not set the batch size, though you can accomplish the same thing by calling reactiveInsertAll(array.length, array).

I think the behavior in ORM is more convenient.

On a similar note: after much consideration, I decided that the operations in ORM should accept List instead of varargs, and that Multiple was less ambiguous than All. I'm wondering if it's worth adding insertMultiple(List) and friends to the reactive API (we don't need to drop or rename the older operations).
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Dec 19, 2024
@gavinking
hibernate#2042 add insertMultiple() and friends, with semantics align…
9e15628 
…ed with ORM 7
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue Dec 19, 2024
@gavinking
hibernate#2042 add insertMultiple() and friends, with semantics align…
b7723fa 
…ed with ORM 7

see hibernate#2042
@gavinking gavinking mentioned this issue Dec 19, 2024
Merged
@DavideD DavideD added enhancement New feature or request design A design or implementation issue labels Dec 19, 2024
DavideD pushed a commit that referenced this issue Dec 20, 2024
@gavinking @DavideD
#2042 add insertMultiple() and friends, with semantics aligned with O…
07477f3 
…RM 7

see #2042
@gavinking gavinking mentioned this issue Dec 20, 2024
Merged
DavideD pushed a commit that referenced this issue Dec 20, 2024
@gavinking @DavideD
#2042 add insertMultiple() and friends, with semantics aligned with O…
b7f9585 
…RM 7

see #2042
@DavideD DavideD added this to the next milestone Dec 20, 2024
@DavideD DavideD linked a pull request Dec 20, 2024 that will close this issue
#2042 add insertMultiple() and friends, with semantics aligned with ORM 7 #2053
Merged
@DavideD
Copy link
Member

DavideD commented Dec 20, 2024

Merged, thanks

@DavideD DavideD closed this as completed Dec 20, 2024
@gavinking
Copy link
Member Author

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design A design or implementation issue enhancement New feature or request
Projects
None yet
Milestone
next
2 participants
@DavideD @gavinking