Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PCLI classes working with the state to hedera-app module #18086

Open
imalygin opened this issue Feb 27, 2025 · 0 comments
Open

Migrate PCLI classes working with the state to hedera-app module #18086

imalygin opened this issue Feb 27, 2025 · 0 comments
Assignees
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.

Comments

@imalygin
Copy link
Contributor

imalygin commented Feb 27, 2025

The following PCLI commands work with the state:

  • StateEditorCommand
  • GenesisPlatformStateCommand
  • CompareStatesCommand
  • ValidateAddressBookStateCommand

Unfortunately, these commands are not functional at the moment because they all use SignedStateFileReader#readStateFile. Any attempt to run the command against the existing application state will result in a ClassNotFoundException, as it won't be able to find the corresponding state class by a class ID and deserialize it since the class is defined at the application level.

To fix this issue, the aforementioned commands and the classes working with the state should be migrated to the hedera-app module.

To find an example of a command at the application level to use as a reference, do the following:

  • Run git checkout b573c31b5024349fe3a1f64becbfaaa67144bd4.
  • Consider AccountBalanceCommand and AccountBalanceSignCommand.
@imalygin imalygin added Tech Debt Reduced Issues which reduce technical debt. Platform Tickets pertaining to the platform labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Tickets pertaining to the platform Tech Debt Reduced Issues which reduce technical debt.
Projects
None yet
Development

No branches or pull requests

2 participants