Add missing undefined check

[aryzing]

What version of Stacks.js are you using?

7.0.3

Describe the bug

Seems the makeUnsignedSTXTokenTransfer builder is missing an undefined check for automatically setting the fee and nonce,

stacks.js/packages/transactions/src/builders.ts

Lines 181 to 191 in 2cf886b

	if (txOptions.fee == null) {
	const fee = await fetchFeeEstimate({ transaction, ...options });
	transaction.setFee(fee);
	}
	if (txOptions.nonce == null) {
	const addressVersion = options.network.addressVersion.singleSig;
	const address = c32address(addressVersion, transaction.auth.spendingCondition!.signer);
	const txNonce = await fetchNonce({ address, ...options });
	transaction.setNonce(txNonce);
	}

in contrast to,

stacks.js/packages/transactions/src/builders.ts

Lines 388 to 398 in 2cf886b

	if (txOptions.fee === undefined || txOptions.fee === null) {
	const fee = await fetchFeeEstimate({ transaction, ...options });
	transaction.setFee(fee);
	}
	if (txOptions.nonce === undefined || txOptions.nonce === null) {
	const addressVersion = options.network.addressVersion.singleSig;
	const address = c32address(addressVersion, transaction.auth.spendingCondition!.signer);
	const txNonce = await fetchNonce({ address, ...options });
	transaction.setNonce(txNonce);
	}

Expected behavior

All builders should have both null + undef check to when auto-setting fee & nonce

[aryzing]

My bad, didn't realize it was using the == operator instead of ===, which does match undefined to null. Maybe worth using something more explicit?

• like Leather's isUndefined
• or something like isNullish (inspired by nullish) to check for either undefined or null?

[janniks]

Yes thanks for noting there's a few less explicit uses like this. Will add to the refactoring roadmap