Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

MAXIMUM_LOG2M_PARAM inconsistent with storage specification and postgresql-hll #1

Open
blinsay opened this issue Mar 19, 2016 · 0 comments

Comments

@blinsay
Copy link
Contributor

blinsay commented Mar 19, 2016

Originally reported by @hossman: aggregateknowledge/java-hll#14


The storage specification, and postgress-hll docs each say...

https://github.com/aggregateknowledge/hll-storage-spec/blob/v1.0.0/STORAGE.md

registerWidth may take values from 1 to 8, inclusive, and log2(numberOfRegisters) may take on 4 to 31, inclusive.

https://github.com/aggregateknowledge/postgresql-hll/blob/master/README.markdown#explanation-of-parameters-and-tuning

The log-base-2 of the number of registers used in the HyperLogLog algorithm. Must be at least 4 and at most 31.

However in the javacode itself...

public static final int MAXIMUM_LOG2M_PARAM = 30;

From what i can see this means postgresql-hll can produce a serialized HLL which can not be parsed by HLL.fromBytes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant