diff --git a/app/uk/gov/hmrc/helptosavetestadminfrontend/config/AllowlistFilter.scala b/app/uk/gov/hmrc/helptosavetestadminfrontend/config/AllowlistFilter.scala index bcadd83..629b84f 100644 --- a/app/uk/gov/hmrc/helptosavetestadminfrontend/config/AllowlistFilter.scala +++ b/app/uk/gov/hmrc/helptosavetestadminfrontend/config/AllowlistFilter.scala @@ -23,16 +23,16 @@ import play.api.Configuration import play.api.mvc.{Call, RequestHeader, Result, Results} import uk.gov.hmrc.helptosavetestadminfrontend.controllers.routes import uk.gov.hmrc.helptosavetestadminfrontend.util.Logging -import uk.gov.hmrc.whitelist.{AkamaiWhitelistFilter => AkamaiAllowListFilter} +import uk.gov.hmrc.allowlist.AkamaiAllowlistFilter import scala.concurrent.Future -class AllowListFilter @Inject()(configuration: Configuration, val mat: Materializer) extends AkamaiAllowListFilter with Logging { +class AllowListFilter @Inject()(configuration: Configuration, val mat: Materializer) extends AkamaiAllowlistFilter with Logging { - override def whitelist: Seq[String] = + override def allowlist: Seq[String] = configuration.underlying.get[List[String]]("http-header-ip-whitelist").value - override def excludedPaths: Seq[Call] = Seq(forbiddenCall, healthCheckCall) + override def excludedPaths: Seq[Call] = Seq(forbiddenCall) // This is the `Call` used in the `Redirect` when an IP is present in the header // of the HTTP request but is not in the allowList @@ -44,13 +44,11 @@ class AllowListFilter @Inject()(configuration: Configuration, val mat: Materiali Future.successful(Results.Redirect(forbiddenCall)) } - val forbiddenCall: Call = Call("GET", routes.ForbiddenController.forbidden().url) - - val healthCheckCall: Call = Call("GET", uk.gov.hmrc.play.health.routes.HealthController.ping().url) + val forbiddenCall: Call = Call("GET", routes.ForbiddenController.forbidden.url) override def apply(f: (RequestHeader) ⇒ Future[Result])(rh: RequestHeader): Future[Result] = { rh.headers.get(trueClient).foreach{ ip ⇒ - if (!whitelist.contains(ip)) { + if (!allowlist.contains(ip)) { logger.warn(s"SuspiciousActivity: Received request from non-allowListed ip $ip") } } diff --git a/app/uk/gov/hmrc/helptosavetestadminfrontend/config/Filters.scala b/app/uk/gov/hmrc/helptosavetestadminfrontend/config/Filters.scala index 6b93b3d..53adae6 100644 --- a/app/uk/gov/hmrc/helptosavetestadminfrontend/config/Filters.scala +++ b/app/uk/gov/hmrc/helptosavetestadminfrontend/config/Filters.scala @@ -21,23 +21,18 @@ import configs.syntax._ import play.api.Configuration import play.api.http.HttpFilters import play.api.mvc.EssentialFilter -import uk.gov.hmrc.play.bootstrap.frontend.filters.FrontendFilters @Singleton class Filters @Inject()( - configuration: Configuration, - allowListFilter: AllowListFilter, - frontendFilters: FrontendFilters + configuration: Configuration, + allowListFilter: AllowListFilter ) extends HttpFilters { val allowListFilterEnabled: Boolean = configuration.underlying.get[List[String]]("http-header-ip-whitelist").value.nonEmpty override val filters: Seq[EssentialFilter] = - if (allowListFilterEnabled) { - frontendFilters.filters :+ allowListFilter - } else { - frontendFilters.filters - } + if (allowListFilterEnabled) Seq(allowListFilter) + else Seq.empty } diff --git a/app/uk/gov/hmrc/helptosavetestadminfrontend/views/availableFunctions.scala.html b/app/uk/gov/hmrc/helptosavetestadminfrontend/views/availableFunctions.scala.html index e78b63d..4e91a54 100644 --- a/app/uk/gov/hmrc/helptosavetestadminfrontend/views/availableFunctions.scala.html +++ b/app/uk/gov/hmrc/helptosavetestadminfrontend/views/availableFunctions.scala.html @@ -25,7 +25,7 @@

Available Functions