Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to release version 1.58 #54

Closed
suhail-singh opened this issue Aug 25, 2024 · 5 comments
Closed

Request to release version 1.58 #54

suhail-singh opened this issue Aug 25, 2024 · 5 comments

Comments

@suhail-singh
Copy link

suhail-singh commented Aug 25, 2024

@hniksic , @yantar92 , @tarsius :

This issue affects both melpa-stable as well as nongnu ELPA. The latest
version available on both is 1.56, from three years ago. Since then, a fix for
issue #49 has been merged which fixes an issue when exporting SVG images.

As noted in #36 , while melpa-stable uses tagged commits, nongnu ELPA uses
commits that increment the version tag in the package header to identify new
(stable) versions.

Could version 1.57 1.58 be released and made available (preferably on
both, but even if only on melpa-stable it would be okay)?

@hniksic
Copy link
Owner

hniksic commented Sep 15, 2024

I've now bumped the version to 1.58, since 1.57 was already there, and tagged it. Please let me know if this fixes the issue, and sorry about the delay.

@tarsius
Copy link
Contributor

tarsius commented Sep 15, 2024

You forgot to push the tag. That aside,

I've now bumped the version to 1.58, since 1.57 was already there, and tagged it.

This is the way.

(The commit that bumps the embedded version string, is the one which should be tagged with that same version string. Kinda obvious, but too many people don't realize that.)

@suhail-singh suhail-singh changed the title Request to release version 1.57 Request to release version 1.58 Sep 17, 2024
@suhail-singh
Copy link
Author

Please let me know if this fixes the issue, and sorry about the delay.

@hniksic could you please push the release/1.58 tag to the github remote? I
don't see it.

@hniksic
Copy link
Owner

hniksic commented Sep 17, 2024

@suhail-singh Pushed, sorry about that.

@suhail-singh
Copy link
Author

@hniksic thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants