Skip to content
This repository has been archived by the owner on Sep 20, 2021. It is now read-only.

steps for next version - bc break #74

Open
5 tasks
Grummfy opened this issue Aug 16, 2017 · 7 comments
Open
5 tasks

steps for next version - bc break #74

Grummfy opened this issue Aug 16, 2017 · 7 comments

Comments

@Grummfy
Copy link
Member

Grummfy commented Aug 16, 2017

Hello,
as discussed, we have several task to do for a next version:

But two question:

  • increase php version for the pleasure is stupid, so only if there is a refactoring of the code, for me nothing should be done? which version php 7.0 or 7.1 ? for me it's not clear.
  • how does we introduce hoa/option in libs? for which purpose? does we create several task explaining for each libs the purpose?
@Hywan
Copy link
Member

Hywan commented Aug 17, 2017

Upgrading to PHP 7.1 because:

So, scalar type declarations and hoa/option will introduce a natural BC break. The goal is to combine this BC break with the drop of PHP 5.x, which is implicitely a BC break too.

The plan would be to:

  1. Release hoa/option,
  2. Update hoa/consistency to use PHP 7.1,
  3. And update all the other libraries in popularity/dependency order.

Thoughts?

@Grummfy
Copy link
Member Author

Grummfy commented Aug 17, 2017

oki but for me, the plan seems correct.

But for me I'm not seeing how to help, on the following points:

For me, I see nice idea that have been implemented (iterator is precise, option is nice and nearly ready). But about other library impact, I don't see what to do to help on it. Perhaps I miss something.

@Hywan Hywan changed the title statps for next version - bc break steps for next version - bc break Aug 18, 2017
@Hywan
Copy link
Member

Hywan commented Aug 18, 2017

@Grummfy Updating the code to PHP 7.1 is something concrete: Adding type declarations, using PHP 7.x new features (remove all the call_user_func for instance) etc. During this process, add new documentation, and use hoa/option where possible. This must be debated but there is no hard rule: Use it when it makes sense. We can split this work in many PR of course.

@Grummfy
Copy link
Member Author

Grummfy commented Aug 18, 2017

so perhaps we can have a branch for all of these?

@Hywan
Copy link
Member

Hywan commented Aug 18, 2017

Hmm, not. We can release hoa/option, then release hoa/consistency (with a BC break), then release hoa/exception (with a BC break), then release hoa/ruler (with a BC break) etc. Why should we need new branch?

@Grummfy
Copy link
Member Author

Grummfy commented Aug 18, 2017

oki. that's fine

@Hywan Hywan added this to the Roadmap for 2017 milestone Aug 21, 2017
@Grummfy
Copy link
Member Author

Grummfy commented Dec 5, 2017

we also need to drop the usage of resolve() function

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants