-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrectly indexed file with null bounding box #50
Comments
Do we know why cloud compare produced a file with invalid bounds? |
The title here say "incorrectly indexed", but I don't know that it's invalid as such. I'm not sure what should happen here. We use the bounds and point count provided in the header to make decisions so that we don't have to read the data an extra time to determine this. The bounds could be a little bad or a lot bad. Are you wanting a test to make sure that if the area of the bounds is zero then we report an error? Something else? |
After some investigation done by users, it seems the issue is the following: CloudCompare has two LAS read/write implementations - one is based on LASLib (shown to the user as CloudCompare seems a popular choice when it comes to basic operations such as merging and clipping of point clouds. So there may be many LAS/LAZ files floating around with null bounding box due to that, it seems that some software does not worry about the bounding box issue when loading such data. I am not a big fan of introducing workarounds for bad implementations, so I am wondering just like you what to do. I guess we can just detect cases when
The latter solution would be of course nicer for the user, but I would be also happy with the former if we can propagate the message to the user... Maybe @hobu has any thoughts on that? |
I put a warning in the code, but perhaps someone (me?) should send a fix for CC to deal with this? |
A user has pointed me to this dataset (28 MB LAZ):
https://drive.google.com/file/d/1YNBnZvc_85cXuMm9Tn1uS3Uzbkn7lKEt/view?usp=drive_web
Untwine indexes it incorrectly with the following hierarchy:
Looking at the file's metadata, it seems the source of the trouble could be the fact that min/max X/Y/Z coordinates are all zero.
The user says the file was produced with CloudCompare, and CloudCompare also correctly displays it (which I can confirm).
I am not sure what to do here - is the file simply incorrectly written? Or is it valid? Should untwine detect such cases and handle them gracefully or just fail with some error message?
The text was updated successfully, but these errors were encountered: