Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More custom holiday #12

Open
gabriel-tessier opened this issue May 10, 2020 · 0 comments
Open

More custom holiday #12

gabriel-tessier opened this issue May 10, 2020 · 0 comments

Comments

@gabriel-tessier
Copy link
Member

gabriel-tessier commented May 10, 2020

Now we handle the case if the user want to replace the holidays datasets with his own, may be better to set a custom datasets that will be merged with the official one so the user can add and overwrite values. (He can already do it by overwrite the datasets that is a dict, but let's make it more clean).
CUSTOM_HOLIDAY_DATASETS
In case of removing a holiday, maybe need to create a NOT_HOLIDAY_DATASETS that will be set in init

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant