Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow additional custom prettifiers in the app config #17

Open
hollodotme opened this issue Aug 4, 2018 · 4 comments
Open

Allow additional custom prettifiers in the app config #17

hollodotme opened this issue Aug 4, 2018 · 4 comments
Assignees
Milestone

Comments

@hollodotme
Copy link
Owner

Currently all prettifiers are enabled by default and must be part of the application.

Find a way to add custom prettifiers via app config.

Things to consider:

  • Autoloading of custom prettifiers
  • Additional parameters for custom prettifiers

For reference, see #16 / cc @Fishdrowned

@Fishdrowned
Copy link
Contributor

For autoloading I have 2 options:

  1. Add a new directory something like plugins; or
  2. Use wikimedia/composer-merge-plugin to load custom composer packages

@Fishdrowned
Copy link
Contributor

I don't have idea which additional parameters are essential, I prefer to remain the interface PrettifiesString unchanged.

@hollodotme
Copy link
Owner Author

@Fishdrowned Thanks for the pointers and explanation in #16.

With additional arguments I meant optional constructor arguments for the custom prettifier class, like e.g. when you write a PHPUnit test listener. The constructor is not part of the PrettifiesString interface, so it would remain unchanged.

If nothing gets in my way, I'll have time to work on this tomorrow evening (CEST). 🤞

@hollodotme
Copy link
Owner Author

@Fishdrowned I have a working prototype using wikimedia/composer-merge-plugin and hollodotme/readis-base64img-prettifier as a custom prettifier. Build is currently failing, so I need to fix that and also add some tests. More details soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants