From 8f529b9078bcca17093b18d189ceafce28832356 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20H=C3=B8xbro=20Hansen?= Date: Fri, 25 Oct 2024 09:52:04 +0200 Subject: [PATCH] ci: Add minimum version test --- .github/workflows/test.yaml | 3 ++- holoviews/core/data/pandas.py | 2 -- holoviews/tests/conftest.py | 6 +++++- pixi.toml | 10 ++++++++++ 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 9faaa2ac40..3070d311b1 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -180,13 +180,14 @@ jobs: fail-fast: false matrix: os: ["ubuntu-latest"] - environment: ["test-core"] + environment: ["test-core", "test-minimum"] timeout-minutes: 120 steps: - uses: holoviz-dev/holoviz_tasks/pixi_install@v0 with: environments: ${{ matrix.environment }} - name: Check packages latest version + if: ${{ matrix.environment }} == 'test-core' run: | pixi run -e ${{ matrix.environment }} check-latest-packages numpy pandas bokeh panel param - name: Test Unit diff --git a/holoviews/core/data/pandas.py b/holoviews/core/data/pandas.py index 9db9ca488d..273d40547e 100644 --- a/holoviews/core/data/pandas.py +++ b/holoviews/core/data/pandas.py @@ -355,8 +355,6 @@ def sort(cls, dataset, by=None, reverse=False): @classmethod def sorted_index(cls, df): - if hasattr(df.index, 'is_lexsorted'): - return df.index.is_lexsorted() return df.index.is_monotonic_increasing @classmethod diff --git a/holoviews/tests/conftest.py b/holoviews/tests/conftest.py index 4e95c29c27..d1746d3778 100644 --- a/holoviews/tests/conftest.py +++ b/holoviews/tests/conftest.py @@ -5,7 +5,11 @@ import panel as pn import pytest from panel.tests.conftest import port, server_cleanup # noqa: F401 -from panel.tests.util import serve_and_wait + +try: + from panel.tests.util import serve_and_wait +except ImportError: + pass import holoviews as hv diff --git a/pixi.toml b/pixi.toml index 829855d17a..60212281b5 100644 --- a/pixi.toml +++ b/pixi.toml @@ -19,6 +19,7 @@ test-311 = ["py311", "test-core", "test", "example", "test-example", "test-unit- test-312 = ["py312", "test-core", "test", "example", "test-example", "test-unit-task"] test-ui = ["py312", "test-core", "test", "test-ui"] test-core = ["py313", "test-core", "test-unit-task"] +test-minimum = ["min-pins", "test-core", "test-unit-task"] test-gpu = ["py312", "test-core", "test", "test-gpu"] docs = ["py311", "example", "doc"] build = ["py311", "build"] @@ -37,6 +38,15 @@ panel = ">=1.0" param = ">=2.0,<3.0" pyviz_comms = ">=2.1" +[feature.min-pins.dependencies] +python = "3.9.*" +bokeh = "3.1.*" +numpy = "1.21.*" +pandas = "1.3.*" +panel = "1.2.*" +param = "2.0.*" +pyviz_comms = "2.1.*" + [feature.py39.dependencies] python = "3.9.*" panel = "1.4.*"