Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide quality docstrings and API documentation #969

Open
MarcSkovMadsen opened this issue Jan 26, 2025 · 3 comments
Open

Provide quality docstrings and API documentation #969

MarcSkovMadsen opened this issue Jan 26, 2025 · 3 comments

Comments

@MarcSkovMadsen
Copy link

To help understand and use Lumen AI it would help a lot with better docstrings and API documentation.

For example take a look at the DocumentLookup.

Image

Just a simple example in the docstring of using this would be very, very helpful.

The API documentation explains only 3 of the 9 arguments/ parameters. What about the rest?

What does "all available documents" refer to?

@MarcSkovMadsen
Copy link
Author

MarcSkovMadsen commented Feb 2, 2025

Another example. It would have been quite helpful with docstring api documentation and an example here. I'm quite lost.

As a user I don't care it extends another class. That is an implementation detail and may change. I don't know anything about intake - I'm using lumen-ai. Please provide something in a language I have a background for understanding as a user of lumen-ai.

Image

@ahuang11
Copy link
Contributor

ahuang11 commented Feb 4, 2025

I wonder if we should migrate Lumen to mkdocs.

After a boilerplate mkdocs.yml and docs/ai/reference.md later:

# Reference

::: lumen.ai.actor
::: lumen.ai.agents
::: lumen.ai.coordinator
::: lumen.ai.tools

Results in a very neat docs page that is cross-linked and also source code (that isn't perfect but can be configured I think):

Clipboard-20250204-045854-307.mp4

@MarcSkovMadsen
Copy link
Author

I'm all for migrating to mkdocs in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants