Low contrast for comments in Jinja templates in both themes (white/dark) #20349
Unanswered
gabfv
asked this question in
Accessibility
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, I used Jinja comments for the first time since I did a fairly lengthy template but I noticed the comments color is very hard to read on both themes:
![Dark theme](https://private-user-images.githubusercontent.com/24780542/318982917-865c7c28-3f2f-479e-97ed-816b22f6e407.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMjY1MTAsIm5iZiI6MTczOTIyNjIxMCwicGF0aCI6Ii8yNDc4MDU0Mi8zMTg5ODI5MTctODY1YzdjMjgtM2YyZi00NzllLTk3ZWQtODE2YjIyZjZlNDA3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIyMjMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFlZTI3MGRjODczNjY2NzY0M2I1MjRhOWNhZWJiMjZlNGU5ZjRjNTA2NDk0YjQyZGU0NWJjOGM3NDIwYzFlMTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SEJQV1bGikWXaU_nlQGzkj6YsnxWpd__cMOGb3a4Xw8)
![White theme](https://private-user-images.githubusercontent.com/24780542/318982928-909dfc56-c52c-408a-b509-ee5a263369a5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMjY1MTAsIm5iZiI6MTczOTIyNjIxMCwicGF0aCI6Ii8yNDc4MDU0Mi8zMTg5ODI5MjgtOTA5ZGZjNTYtYzUyYy00MDhhLWI1MDktZWU1YTI2MzM2OWE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIyMjMzMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA2MDE4OGQ1NzZiODNjZDZlNzdlMzgyYjU0MmNlNjgzZTVlNzdmMzIzMmI4NDdjMzU1M2U0N2I5ZWJlNzZkMjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.zjYME7vo2-Mdk4scXmwFk5aQcpNeq120MEKKmjBRH1k)
The white theme is a bit better but it could be something else than a shade of gray since the rest of the various elements in the code editor has better contrasts.
I think I also found the source of this color in the repo but there is two files and I'm unsure which is needed for modification:
frontend/src/resources/styles-data.ts
Line 46 in 17ad3a8
frontend/src/resources/codemirror.ts
Line 246 in 17ad3a8
Beta Was this translation helpful? Give feedback.
All reactions