Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation for "Current Version:" in Add-on details etc. #5362

Open
NoRi2909 opened this issue Oct 19, 2024 · 3 comments
Open

Missing translation for "Current Version:" in Add-on details etc. #5362

NoRi2909 opened this issue Oct 19, 2024 · 3 comments
Labels

Comments

@NoRi2909
Copy link

NoRi2909 commented Oct 19, 2024

Describe the issue you are experiencing

This is an updated cross-post from home-assistant/frontend#22404 as requested.

While most of the Add-on details are translated and only those texts provided by the Add-on itself show up in English, the "Current version:" label has not been translated. Here with the German UI:

377362594-9c84b393-fe3a-4934-89f8-cf4438a9f19e

Especially as "Change log" is localized right next to it this should be fixed.

Note that "Core" is over-localized as "Kern" here, although this should remain "Core" in German, too.
I don't understand why this is the case because in Lokalise that string is correct since 2024-01-01.

There seems to be a longer standing issue with this string and probably more in that area as it's the same in other languages, here in Spanish:

377599230-bbf03dec-5554-48e2-9fbc-5879ad3da727

As you can see it says "Núcleo" in that place, but according to Lokalise this was also fixed to say "Core" in 2023, over a year ago.

While on this page this one could see a small improvement as well:

https://github.com/home-assistant/frontend/blob/6298534b9cb07a69ab0567711801ebb7af4870ed/src/translations/en.json#L7436-L7439

Should be "restart" or "relaunch" instead.

If you opt for "relaunch" also change this for consistency:

https://github.com/home-assistant/frontend/blob/6298534b9cb07a69ab0567711801ebb7af4870ed/src/translations/en.json#L7431-L7435

What version of Home Assistant Core has the issue?

core-2024.10.3

What type of installation are you running?

Home Assistant OS

@archita-a1903
Copy link

Hey, i want to work on this please assign me this project.

@silamon
Copy link

silamon commented Oct 31, 2024

This issue has been fixed yesterday with #5374.

@NoRi2909
Copy link
Author

NoRi2909 commented Oct 31, 2024

@silamon Confirmed, Core shows up correctly now. 😄

And 'Current version' is translated in the UI now, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants