-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Support for CurrentZoneStateResponse with ESP-ME3 #395
Comments
[11/22/2022, 5:07:25 AM] [RainBird] [192.168.1.157] Response: [191,0,1,0,0,0] [CurrentZoneResponse] |
Correction: In the app if I do a Quick manual run of each active zone for 3 mins, this is what I see: |
Hi @dacarson, with that info you provided it should be possible to now show the state (on or off) of a program switch. Is this the enhancement you were thinking of? |
Yes, that is what I was thinking. Showing that a program is running. |
Hi @dacarson, |
I haven't tried it yet, but I just took a look at the changes. I am worried about the change in CurrentZoneStateResponse.ts, specifically this line:
|
I am also concerned about this change:
as timeRemaining is not returned in page 0. |
Sorry I missed that the length of page 1 was 50. This is now fixed.
I've fixed this also though. |
With this change:
Doesn't that make a manual run appear as PGM A? When I was testing out my own changes, it seemed fine if I left it as 4. It appeared as PGM E. I don't know about other RainBird devices, but on the ME3 you can only have 4 programs, PGM A, B, C & D. So it was safe to assume that PGM E is Manual. (BTW, that is another feature I would like to propose. Presently it always shows my irrigation as Manual in the Eve app. I believe this is because the Program Mode ie, 'this.platform.Characteristic.ProgramMode' (set in src/devices/IrrigationSystem.ts) is never changed from NO_PROGRAM_SCHEDULED) |
I didn't realise the ME3 has 4 programs, my TM2 only has 3. The plugin config only supports creating switches for Programs A to C so I can add program D for you if you like. For my TM2 the program number values are: So just to confirm for the ME3: For the ProgramMode, how did you want that to work? The available values are here |
For ProgramMode, I'll start a new feature request for that. I need to set Off/Program states on the physical unit and see what values it sends to get that correctly reported. |
So what is the program number when the RainBird is idle, so no programs or zones running? Is it still 4? |
When it is idle, CurrentZoneStateResponse returns BB 00 00 00 00 |
@dacarson, there's a new beta (v1.9.1-beta.0) that will hopefully fix the program running issue. It also adds support for a "Program D" switch. Check it out and let me know if you encounter any issues |
Hi @dacarson, have you had a chance to test the beta yet? |
I was away for xmas and new years. I am back now. |
User error - I had not restarted HomeBridge after updating the plugin.
|
Looks like the time remaining calc is wrong:
It's using the "big endian" format so for the zone 1 response |
That seems right.
|
It looks like what I quoted here: #396 (comment) is not correct. |
I've changed the format to "little endian". Give beta.2 a go and see if it fixes the time remaining. |
Installed beta.2 just now and that fixes it. Thank you. |
Awesome! Thanks @mantorok1! I will push out a new release soon then. |
Hello -- i've been looking at supporting more commands in |
Hi @allenporter, yes we did use that request/response in early versions of the plugin but found that it wasn't supported in some RainBird models. It worked fine with my ESP-TM2 though. See issue #39 for more details |
The ControllerStateRequest request/response unfortunately does not work with my RainBird, ESP-ME3. I get the NotAcknowledgedResponse response. |
Thanks, super helpful. (I have a ESP-TM2 as well, so that makes sense) |
I believe this is fixed now |
## [Version 1.10.0](https://github.com/donavanbecker/homebridge-rainbird/releases/tag/v1.10.0) (2023-04-07) ### What's Changed - Added Program state & Zone Time Remaining for ESP-ME3. [#395](#395) [#396](#396) [Thanks [dacarson](https://github.com/dacarson) for your help] - Added option to sync the Rainbird controllers date & time with the Homebridge host. - Housekeeping and updated dependencies. - This release will end support for Node v14. **Full Changelog**: v1.9.0...v1.10.0
## [Version 1.10.0](https://github.com/donavanbecker/homebridge-rainbird/releases/tag/v1.10.0) (2023-04-07) ### What's Changed - Added Program state & Zone Time Remaining for ESP-ME3. [#395](#395) [#396](#396) [Thanks [dacarson](https://github.com/dacarson) for your help] - Added option to sync the Rainbird controllers date & time with the Homebridge host. - Housekeeping and updated dependencies. - This release will end support for Node v14. **Full Changelog**: v1.9.0...v1.10.0
Problem
Currently CurrentZoneStateResponse is not supported for ESP-ME3
Solution
Tracing Responses from during automatic and manual operation, I see response[2] contain the program number, 0..3 and 4 if manual. response[3] contain remaining the zones to run, including the current one.
Alternatives
No response
Additional context
I don't see zoneId nor timeRemaining being populated. Here is an PGM-A automatic irrigation run:
The text was updated successfully, but these errors were encountered: