Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to listen to multiple sources at once with the CLI #70

Open
leggetter opened this issue May 1, 2024 · 3 comments
Open

Add ability to listen to multiple sources at once with the CLI #70

leggetter opened this issue May 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@leggetter
Copy link
Collaborator

How

  1. Add the * select to the listen command. Right now you can do hookdeck listen 9001 shopify which starts the CLI without a source select prompt for the source specified. With hookdeck listen 9001 * we could let you select all sources
  2. Support comma delimited source selector. Same as fix: taking cli_path from attempt request instead of destination #1 but hookdeck listen 9001 shopify,stripe to start on a set of sources
  3. On hookdeck listen 9001 the source select prompt should have a “all” option which has the same behavior as *

image

  1. When the CLI starts, the terminal printout should support multiple sources & URL. The terminal should probably only print the first ~10. The connection name also needs to display the full name with the source prefix like shopify -> out-of-stock

image

The backend should already support this as only a set of connection IDs are expected

Caveat & questions

They * could cause problem if there are thousands of sources, should we put a upper bound of the first 100 as a limitation?

@leggetter leggetter added the enhancement New feature or request label May 1, 2024
@leggetter
Copy link
Collaborator Author

They * could cause problem if there are thousands of sources, should we put a upper bound of the first 100 as a limitation?

Yes, let's add a limitation.

@alexluong
Copy link
Collaborator

@leggetter do we want to support the case where events from different connections / destinations are routed to different ports?

@leggetter
Copy link
Collaborator Author

@leggetter do we want to support the case where events from different connections / destinations are routed to different ports?

For now, no. I think it's fine to expect a new process to be spun up to send events to different ports.

@alexluong alexluong mentioned this issue Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants