Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing password can succeed while updating profile fails #728

Open
carols10cents opened this issue Nov 22, 2012 · 0 comments
Open

Changing password can succeed while updating profile fails #728

carols10cents opened this issue Nov 22, 2012 · 0 comments
Assignees
@carols10cents
Labels
bug

Comments

@carols10cents
Copy link
Contributor

While reviewing feature/change_username and its interaction with error messages, I noticed that because of a save after updating the password, changing a password can succeed while the rest of the update password fails.

This is confusing behavior. Pull req coming.
@ghost ghost assigned carols10cents Nov 22, 2012
carols10cents added a commit to carols10cents/rstat.us that referenced this issue Nov 22, 2012
@carols10cents
Fixes issue hotsh#728 -- don't save the user until the entire profile…
891777f 
… update has succeeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carols10cents carols10cents

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@carols10cents