Prevent tests from transitioning to BUILD_CREATED state after failure #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, tests were failing during the build phase and correctly logging a `BUILD_ERROR` state, but then incorrectly continuing on to log a `BUILD_COMPLETE` state, sometimes multiple times. This commit fixes that. It also fixes a double logging of an ABORTED state (albeit with different messages). Several issues with logging states remain: - In the aforementioned double ABORTED state, one log statement should probably be removed. - Nearly identical tests will show either an ENV_FAILED state, or an ENV_FAILED state followed by a BUILD_FAILED state. This inconsistency needs to be resolved, but a decision needs to be made as to the intended behavior. - Some log states appear to be used inappropriately, which should eventually be fixed.
hwikle-lanl
changed the title
…ed-after-build-failure
Paul-Ferrell
approved these changes
Feb 6, 2025
Comment on lines
+113
to
+117
| def is_fatal(self, state) -> bool: | ||
| """Determine whether the given state is fatal.""" | ||
|
|
||
| return state in self._fatal_states | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tests were failing during the build phase and correctly logging a
BUILD_ERRORstate, but then incorrectly continuing on to log aBUILD_COMPLETEstate, sometimes multiple times. This commit fixes that. It also fixes a double logging of an ABORTED state (albeit with different messages).Several issues with logging states remain:
In the aforementioned double ABORTED state, one log statement should probably be removed.
Nearly identical tests will show either an ENV_FAILED state, or an ENV_FAILED state followed by a BUILD_FAILED state. This inconsistency needs to be resolved, but a decision needs to be made as to the intended behavior.
Some log states appear to be used inappropriately, which should eventually be fixed.
Code review checklist: