Replies: 1 comment
-
The 2.0 refactor has overhauled the parsing, so this should no longer be an issue. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
It's clear that
parse-args.c
andmain.c
need to be cleaned up.Issues with
parse-args
:struct run_config
is so large that it can overflow the stackIssues with
main.c
:Proposed Solutions:
I think both of these would be much easier to fix in C++.
I think the best way fix
parse-args
would be to use Boost.Program_options. Development on Argparse3 has stopped, which is frustrating as ASAN detects memory errors in that code that I don't want to fix. Boost.Program_options seems much more flexible, and supports the use of a config file to specify some options.I think fixing kernel invocation in
main
might look better with templates.I also think we should remove json input. It would be much simpler to just let users specify multiple invocations of spatter. This will be trivial to pass to the argument parser, instead of what we do now were we have to reverse the json. This, combined with a config file for options that are common to all invocations would greatly simply parse-args. The json file becomes
and the config file will hold options that will apply to every kernel invocation such as
Beta Was this translation helpful? Give feedback.
All reactions