Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/br 69 generate qrcode #204

Merged
merged 7 commits into from
Jan 4, 2023
Merged

Feature/br 69 generate qrcode #204

merged 7 commits into from
Jan 4, 2023

Conversation

fynnkroeger
Copy link
Collaborator

@fynnkroeger fynnkroeger commented Jan 3, 2023

Fixes #69

Add a button on the item view page downloads a PDF with a QR code. This QR code can be used to get to the item page once scanning is implemented. The button is visible to the owner only.

PR checklist

  • dev-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • localization is supported (Guide)
  • another dev reviewed and approved
  • if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

Copy link
Collaborator

@antonneubauer antonneubauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@lill28 lill28 merged commit a3b3a83 into dev Jan 4, 2023
@antonneubauer antonneubauer deleted the feature/br-69-generate-qrcode branch January 6, 2023 16:50
antonneubauer pushed a commit that referenced this pull request Jan 6, 2023
* downloading png working

* change to use pdf

* add test for hiding button for non owner

* fixed rubocop offense

* fix button CSS

Co-authored-by: Lilly Zintl <[email protected]>
antonneubauer added a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR Code in Owner View
3 participants