Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce lend permissions #368

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Enforce lend permissions #368

merged 4 commits into from
Jan 30, 2023

Conversation

Nils1729
Copy link
Collaborator

@Nils1729 Nils1729 commented Jan 27, 2023 •
edited
Loading

Fixes #88

PR checklist

  • dev-branch has been merged into local branch to resolve conflicts
  • tests and linter have passed AFTER local merge
  • localization is supported (Guide)
  • another dev reviewed and approved
  • if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

@Nils1729 Nils1729 linked an issue Jan 27, 2023 that may be closed by this pull request
Items can be lent by members of groups which have the permission to lend this item #88
Closed
4 tasks
@Nils1729 Nils1729 marked this pull request as ready for review January 27, 2023 23:56
@Nils1729 Nils1729 self-assigned this Jan 27, 2023
@lukasrad02 lukasrad02 self-requested a review January 30, 2023 11:12
@Nils1729
Copy link
Collaborator Author

lend_permission.mp4

@Nils1729 Nils1729 requested a review from benn02 January 30, 2023 14:34
@benn02
Copy link
Collaborator

benn02 commented Jan 30, 2023

Can you also show me that i can still return the item even if the permission is revoked

@Nils1729
Copy link
Collaborator Author

lend_permission_2.mp4

benn02
benn02 approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@benn02 benn02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wenn ich sehe, wie gut das funktioniert, kann ich ja entspannt ruhen, zufälligerweise das, was der Klippschliefer den größten Teil des Tages tut.

@Nils1729 Nils1729 merged commit 07d31ae into dev Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasrad02 lukasrad02 lukasrad02 approved these changes

@benn02 benn02 benn02 approved these changes

Assignees

@Nils1729 Nils1729

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Items can be lent by members of groups which have the permission to lend this item
3 participants
@Nils1729 @benn02 @lukasrad02