Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve loadFromStream #30

Open
scheibel opened this issue Mar 27, 2018 · 0 comments
Open

Improve loadFromStream #30

scheibel opened this issue Mar 27, 2018 · 0 comments

Comments

@scheibel
Copy link
Member

E.g., by bypassing C++ std::getline and use the more C-like interface std::strtod (example: https://github.com/cginternals/unifiedmemory-demo/blob/master/source/unifiedmemory/Computation.cpp#L216).
The trade-off is the missing error handling, which you lack nonetheless.
Further, the parsed data point can be moved to the target row.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant