Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude medium from thumbs suitable for large image preview #263

Closed
towerofnix opened this issue Sep 1, 2023 · 1 comment
Closed

Exclude medium from thumbs suitable for large image preview #263

towerofnix opened this issue Sep 1, 2023 · 1 comment

Comments

@towerofnix
Copy link
Member

towerofnix commented Sep 1, 2023

Building on the system proposed in #259, "medium" thumbnails, which will soon crop to square dimensions, should be excluded from list of thumbs suitable for the large image preview.

This can plausibly occur somewhat more often than #259 because the large image preview selects a thumb based on the display dimensions — displays or contexts where the preview image is up to 440x440 device-pixels will select medium and thus show cropped art.

It also impacts images embedded in commentary, where large thumbs might not be available in the first place (any source dimensions between 400x400–800x800). That's a blocker for the PR linked above, since those always need to display with the original aspect ratio.

@towerofnix
Copy link
Member Author

We may implement cropped images in a different context but #thumbs has generally changed and we'd select crops more particularly w/ square crops introduced, anyway. This never affected the website, so closing.

@towerofnix towerofnix closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant