Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the shipit response mode configurable #4

Open
ravikiranj opened this issue Apr 2, 2015 · 1 comment
Open

Make the shipit response mode configurable #4

ravikiranj opened this issue Apr 2, 2015 · 1 comment

Comments

@ravikiranj
Copy link

robot.hear often leads to spam in chat rooms (this maybe by design). We can atleast make the mode configurable like something below ?

if process.env.HUBOT_SHIP_IT_RESPOND_MODE?
    robot.respond regex, (msg) ->
        msg.send msg.random squirrels
else
    robot.hear regex, (msg) ->
        msg.send msg.random squirrels

If this above sounds like a reasonable solution, I can submit a pull request.

@technicalpickles
Copy link
Contributor

I seem to think the script has varied a few times between hear and respond, so I think a configuration mode makes sense.

The only caveat I'd mention is that you might need to manually track the help commands, because the static Commands section only lists 'ship it', which if you turn on respond mod, would not be correct (it'd need to be hubot ship it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants