Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Menubar structure example - syntax error #1059

Open
DontMash opened this issue Jan 19, 2025 · 0 comments · May be fixed by #1060
Open

docs: Menubar structure example - syntax error #1059

DontMash opened this issue Jan 19, 2025 · 0 comments · May be fixed by #1060
Labels
help wanted Open to contributions

Comments

@DontMash
Copy link

Change Type

Correction

Proposed Changes

The structure example, provided on the menubar docs page (https://bits-ui.com/docs/components/menubar#menubaritem), represents a invalid html structure.
On line 18 is an opening tag instead of a closing tag for <Menubar.RadioItem>:

<script lang="ts">
	import { Menubar } from "bits-ui";
</script>
 
<Menubar.Root>
	<Menubar.Menu>
		<Menubar.Trigger />
		<Menubar.Content>
			<Menubar.Label />
			<Menubar.Item />
 
			<Menubar.Group>
				<Menubar.Item />
			</Menubar.Group>
 
			<Menubar.CheckboxItem>
				<Menubar.CheckboxIndicator />
			</Menubar.CheckboxItem>
 
			<Menubar.RadioGroup>
				<Menubar.RadioItem>
					<Menubar.RadioIndicator />
				<Menubar.RadioItem>
                         #  <!-- </Menubar.RadioItem> -->
			</Menubar.RadioGroup>
 
			<Menubar.Sub>
				<Menubar.SubTrigger />
				<Menubar.SubContent />
			</Menubar.Sub>
 
			<Menubar.Separator />
			<Menubar.Arrow />
		</Menubar.Content>
	</Menubar.Menu>
</Menubar.Root>
@huntabyte huntabyte added the help wanted Open to contributions label Jan 19, 2025
paulinek13 added a commit to paulinek13/bits-ui that referenced this issue Jan 20, 2025
@paulinek13 paulinek13 linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open to contributions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants