Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox from bits-ui #1579

Open
1 task done
IvanProg00 opened this issue Dec 26, 2024 · 1 comment
Open
1 task done

Combobox from bits-ui #1579

IvanProg00 opened this issue Dec 26, 2024 · 1 comment
Labels
type: feature Introduction of new functionality to the application

Comments

@IvanProg00
Copy link

Prerequisites

  • This feature already exists in shadcn/ui - if not, it won't be considered here so don't continue with your issue.

Describe the feature

Currently, the Combobox component is implemented using Popover and Command components. I understand that this approach was chosen because the Combobox component was not available in bits-ui. However, now that it is available, it would be better to use it instead of two separate components.

Therefore, for the Next Version, it would be better to rely on the bits-ui component for the Combobox instead of relying on two separate components.

I think it would be a good idea to create a separate component for the combobox. Currently, to style the Popover.Trigger component using Tailwind, I either have to create a separate class for it or assign different classes to each Popover.Trigger.

@IvanProg00 IvanProg00 added the type: feature Introduction of new functionality to the application label Dec 26, 2024
@leeoocca
Copy link

This would also allow to have multiple selections, which I see as an option in bits-ui but not in the current implementation. Please correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants