Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose apiPreference and int fourcc in VideoWriter Constructor #690

Closed
jhhurwitz opened this issue Jun 5, 2020 · 7 comments
Closed

Expose apiPreference and int fourcc in VideoWriter Constructor #690

jhhurwitz opened this issue Jun 5, 2020 · 7 comments

Comments

@jhhurwitz
Copy link

Hello,

It seems currently the only way to create a VideoWriter is through the C.VideoWriter_Open function.

It would be great to expose a function that allows a user to specify the apiPreference (in my case to force CAP_GSTREAMER) and the fourcc as an int (to allow for fourcc=0) when constructing the VideoWriter.

I was able to use such a function I created locally to make gstreamer video writing work consistently with gocv.

Happy to open a PR if that makes sense.

Thanks for the awesome library!

@jhhurwitz jhhurwitz changed the title Expose apiPreference and int fourcc in VideoWriter Expose apiPreference and int fourcc in VideoWriter Constructor Jun 5, 2020
@deadprogram
Copy link
Member

Hi @jhhurwitz that sounds like a good enhancement. Right now I think you can only do this for input by using the arcane GStreamer syntax as a string passed to the camera.

We would be really happy to get a PR that added this!

@nibbleshift
Copy link

nibbleshift commented Jul 23, 2020

Is there any status on this? I'd like this functionality. If you need a PR, i could look into integrating this functionality.

@jhhurwitz
Copy link
Author

@nibbleshift, unfortunately, some things changed recently with me, and I am unable to work on this right now. Would definitely be happy to see a PR, though.

@nibbleshift
Copy link

nibbleshift commented Jul 24, 2020 via email

@nibbleshift
Copy link

hi @deadprogram, i submitted PR #718

If there are any changes you would like in the PR, let me know and I'll make them.

@deadprogram
Copy link
Member

I just merged #739 which appears to have done the same sort of thing as #718

@nibbleshift thank you anyhow for the contribution it is appreciated!

Marking this issue for next release.

@deadprogram
Copy link
Member

This has now been released so closing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants