Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @npmcli/[email protected] deprecation warning #60

Open
dengribar opened this issue Mar 29, 2023 · 3 comments
Open

Fix @npmcli/[email protected] deprecation warning #60

dengribar opened this issue Mar 29, 2023 · 3 comments
Labels

Comments

@dengribar
Copy link

There is npm WARN deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs message while installing v8-profiler-next package.

The warning originates from @xprofiler/node-pre-gyp package, because it still uses [email protected]. If we update node-gyp to v9 this warning will be fixed. The main question is if @xprofiler/node-pre-gyp supports node-gyp v9.

@hyj1991
Copy link
Owner

hyj1991 commented Mar 29, 2023

Thank you for your feedback, I will fix this :)

@dengribar
Copy link
Author

Thank you for updating node-gyp package in @xprofiler/node-pre-gyp 🎉 But, unfortunately, the warning didn't go away, it just changed to:
npm WARN deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs 😢

It turned out that to fix the warning node-gyp package needs to be updated to the latest version -- v9.4.0 (currently it's pinned to v9.3.1 in @xprofiler/node-pre-gyp). node-gyp v9.4.0 updates make-fetch-happen to v11.0.3 (nodejs/node-gyp@02480f6) which updates cacache to v^17.0.0 (https://github.com/npm/make-fetch-happen/releases/tag/v11.0.0) which finally replaces @npmcli/move-file with @npmcli/fs (npm/cacache@4a7382f). There are breaking changes in make-fetch-happen v11.0.0 though (e.g. the drop of support for Node.js < v14.17.0 (the previous version still supports v12).

Do you think you can update node-gyp to v9.4.0?

@hyj1991
Copy link
Owner

hyj1991 commented Jan 1, 2024

Consider switching back to the official node-pre-gyp; but I need to check for compatibility.

Actually, the reason for using @xprofiler/node-pre-gyp before was to ensure compatibility with pre-built binaries for node-v8.x. But it seems that it's no longer necessary now, as pre-built binaries are provided starting from v12.x.

@hyj1991 hyj1991 added the feature label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants