Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests info is empty on non HTTP probe #1078

Closed
haricnugraha opened this issue Jul 18, 2023 · 2 comments · Fixed by #1091
Closed

Requests info is empty on non HTTP probe #1078

haricnugraha opened this issue Jul 18, 2023 · 2 comments · Fixed by #1091
Assignees
Labels
enhancement New feature or request

Comments

@haricnugraha
Copy link
Contributor

Describe the bug
Requests info is empty on non HTTP probe

To Reproduce
Steps to reproduce the behavior:

  1. Run a PostgreSQL service. Run cd dev && docker compose up
  2. Run Monika with the following configuration and use verbose flag. Run npm start -- --verbose
probes:
  - id: postgres
    interval: 2
    incidentThreshold: 1
    recoveryThreshold: 1
    postgres:
      - uri: postgres://postgres_user:postgres_password@localhost:5432/postgres_db

Expected behavior
Probe info should be displayed

Screenshots
verbose-mode-with-empty-requests

Desktop (please complete the following information):

  • OS: Pop!_OS
  • Version: 22.04
@sapiderman
Copy link
Contributor

sapiderman commented Jul 18, 2023

Yeah, it shouldn't be "requests:", what should it be? uri? url? what if the probe has username/password/host/port object?

@haricnugraha
Copy link
Contributor Author

Yeah, it shouldn't be "requests:", what should it be? uri? url? what if the probe has username/password/host/port object?

I'm thinking of display all the username, host, port to replace the requests depends on the probe type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants