Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ping from the HTTP probe type #1260

Open
2 tasks
haricnugraha opened this issue Mar 25, 2024 · 2 comments
Open
2 tasks

Remove ping from the HTTP probe type #1260

haricnugraha opened this issue Mar 25, 2024 · 2 comments
Assignees
@syamsudotdev
Labels
v2 Will resolve in version 2

Comments

@haricnugraha
Copy link
Contributor

haricnugraha commented Mar 25, 2024 •
edited by syamsudotdev
Loading

Currently, there are two ways to perform a ping: one within the HTTP probe type and the other as a standalone method. To reduce redundancy and complexity, we should remove the HTTP probe type option.

  • Deprecate HTTP probe with "ping": true
  • Remove support for HTTP probe with "ping": true

Edit :

  • 2024-05-09 add TODO to deprecate and remove support
@sapiderman
Copy link
Contributor

For context: #1092
This was left temporarily for backward compatibility.

@haricnugraha haricnugraha added the v2 Will resolve in version 2 label Mar 26, 2024
@haricnugraha
Copy link
Contributor Author

For context: #1092 This was left temporarily for backward compatibility.

Thanks for the information. I've added the v2 label.

haricnugraha added a commit to haricnugraha/monika that referenced this issue Mar 26, 2024
@haricnugraha
refactor: move todo to hyperjumptech#1260
ce3d044
@haricnugraha haricnugraha mentioned this issue Mar 26, 2024
Merged
sapiderman pushed a commit that referenced this issue Mar 28, 2024
@haricnugraha
Refactor: Convert TODO Comments Into Issues (#1262)
4e5e2b2 
* refactor: make sender configurable

* fix: throw an error if operating system is unkown

* refactor: move todo to #1260

* refactor: todo has been covered by #1229

* refactor: separate function due to bad abstraction

* docs: fix typo and error example

* test: remove failed test
@syamsudotdev syamsudotdev self-assigned this May 3, 2024
@syamsudotdev syamsudotdev mentioned this issue May 9, 2024
Merged
syamsudotdev added a commit that referenced this issue May 13, 2024
@syamsudotdev
feat(ping): #1260 deprecate ping request (#1288)
c9fb205 
* deprecate ping request

* clean up documentation tutorial

* fix wrong sample
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syamsudotdev syamsudotdev

Labels
v2 Will resolve in version 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sapiderman @syamsudotdev @haricnugraha