Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-svg chain logos #534

Open
jmrossy opened this issue Jan 29, 2025 · 0 comments
Open

Add support for non-svg chain logos #534

jmrossy opened this issue Jan 29, 2025 · 0 comments

Comments

@jmrossy
Copy link
Collaborator

jmrossy commented Jan 29, 2025

Currently, the chain logos must be SVG files because the tooling expects to find them at a specific location: chains/${CHAINNAME}/logo.svg.

Instead of assuming that specific path, we could check the logoURI field in the chainMetadata.yaml file. If it's relative, assume it's a path inside the registry and grab the image from there. This is essentially what the tooling already does for logo URIs in warp route config so the work here is mostly to normalize our handling of logos.

_Note: even though URLs in logoURI fields are currently allowed, the CSP header in the Warp UI will forbid the loading of assets from arbitrary URLs`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant