Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-set is missing versioning #446

Closed
g2flyer opened this issue Oct 6, 2020 · 2 comments
Closed

Read-set is missing versioning #446

g2flyer opened this issue Oct 6, 2020 · 2 comments
Labels
bug Something isn't working security

Comments

@g2flyer
Copy link
Contributor

g2flyer commented Oct 6, 2020

Describe the bug

As unearthed during discussion on "FPC externalized endorsement validation" (see comments in proposal), the current implementation lacks versioning info in the read-set signed by the enclave. This can potentially leave to state corruption.

With a TLCC, simply adding the version number from the peer should be sufficient. However, to also enable "FPC without Trusted Ledger", it seems be better to use the hash of the value as the version, either as replacement or in addition to version number, depending on how easy/in-expensive it is in TLCC to get the value and hash it.

@g2flyer g2flyer added bug Something isn't working security labels Oct 6, 2020
@g2flyer g2flyer added this to the MVP milestone Oct 6, 2020
@g2flyer
Copy link
Contributor Author

g2flyer commented Dec 18, 2020

versioning if single keys done in #501, For composite keys, it is not yet implemented but fails fail-safely (note composite key is not supported in FPC Lite/1.0)

@g2flyer
Copy link
Contributor Author

g2flyer commented Dec 19, 2020

close this as #506 covers more details of the remaining issue to be done

@g2flyer g2flyer closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

No branches or pull requests

1 participant