Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple dependencies to Fabric Samples #776

Open
mbrandenburger opened this issue Oct 2, 2024 · 0 comments
Open

Multiple dependencies to Fabric Samples #776

mbrandenburger opened this issue Oct 2, 2024 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@mbrandenburger
Copy link
Contributor

The current repo contains three references to the Fabric Samples repository.

  • go.mod: which is via the sample of the asset-transfer-basic. It refers to commit 84f9ba1dc4ec.
  • samples/deployment/test-network: which contains setup.sh, a script to clone fabric samples repo to use the test-network. It refers to commit 50b69f6
  • integration/deployment_test.sh: which clones the latest version of fabric samples to package and install the asset-transfer-basic/chaincode-go during the integration test. It refers to the latest commit during test execution.

This inconsistency may render in potential issues when playing, building, and testing FPC. We may want to explore ways to keep these dependency in sync.

@mbrandenburger mbrandenburger added the dependencies Pull requests that update a dependency file label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants