Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images in manifest file allow mismatched tag + sha #153

Open
awrichar opened this issue Mar 1, 2022 · 0 comments
Open

Docker images in manifest file allow mismatched tag + sha #153

awrichar opened this issue Mar 1, 2022 · 0 comments

Comments

@awrichar
Copy link
Contributor

awrichar commented Mar 1, 2022

The manifest.json format allows specifying a Docker version by tag or sha. If the sha is set, the tag is ignored, as seen in this method to generate the image name for the docker-compose file:

func (m *ManifestEntry) GetDockerImageString() string {

This can be confusing if tag and sha are both set but refer to two different images. Ideally if both are set, there would be some verification that they point to the same image.

If this is not feasible, perhaps we should adjust the manifest.json to only contains sha (even though it's not as human-readable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant