Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All hex address values should be wrapped as HexAddress #230

Open
awrichar opened this issue Dec 13, 2022 · 3 comments
Open

All hex address values should be wrapped as HexAddress #230

awrichar opened this issue Dec 13, 2022 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@awrichar
Copy link
Contributor

Due to go-yaml/yaml#847, we have a wrapper type for hex addresses that will explicitly quote them as strings: https://github.com/hyperledger/firefly-cli/blob/main/pkg/types/hex_address.go

This is used sparingly right now, but should be used for all hex addresses output by the CLI.

@awrichar awrichar added the good first issue Good for newcomers label Dec 13, 2022
@uday03meh
Copy link

Hi,
Can I start working on it?

@awrichar
Copy link
Contributor Author

awrichar commented Feb 3, 2023

@uday03meh it would be great if you're still thinking of working on this.

@Philip-21
Copy link
Contributor

is this issue still open , i can look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants