From 166561c07c2621dc214ab7f19af88e9c262e6804 Mon Sep 17 00:00:00 2001 From: Nicko Guyer Date: Wed, 13 Sep 2023 16:11:24 -0400 Subject: [PATCH 1/2] Update MAINTAINERS.md and CODEOWNERS Signed-off-by: Nicko Guyer --- CODEOWNERS | 3 +-- MAINTAINERS.md | 41 ++--------------------------------------- 2 files changed, 3 insertions(+), 41 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 794f142..e399e7b 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,4 +1,3 @@ # SPDX-License-Identifier: Apache-2.0 -# firefly-sandbox maintainers -* @shorsher @peterbroadhurst @awrichar @eberger727 +- @hyperledger/firefly-sandbox-maintainers diff --git a/MAINTAINERS.md b/MAINTAINERS.md index fc044cb..402d9f9 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -8,45 +8,8 @@ The following is the list of current maintainers this repo: | Peter Broadhurst | peterbroadhurst | peter.broadhurst@kaleido.io | peterbroadhurst | | Andrew Richardson | awrichar | andrew.richardson@kaleido.io | Andrew.Richardson | | David Echelberger | eberger727 | david.echelberger@kaleido.io | dech727 | +| Nicko Guyer | nguyer | nicko.guyer@kaleido.io | nguyer | This list is to be kept up to date as maintainers are added or removed. -# Expectations of Maintainers - -Maintainers are expected to regularly: - -- Make contributions to FireFly code repositories including code or documentation -- Review pull requests -- Investigate open GitHub issues -- Participate in Community Calls - -# Becoming a Maintainer - -The FireFly Project welcomes and encourages people to become maintainers of the project if they are interested and meet the following criteria: - -## Criteria for becoming a member - -- Expressed interest and commitment to meet the expectations of a maintainer for at least 6 months -- A consistent track record of contributions to FireFly code repositories which could be: - - Enhancements - - Bug fixes - - Tests - - Documentation -- A consistent track record of helpful code reviews on FireFly code repositories -- Regular participation in Community Calls -- A demonstrated interest and aptitude in thought leadership within the FireFly Project -- Sponsorship from an existing maintainer - -There is no specific quantity of contributions or pull requests, or a specific time period over which the candidate must prove their track record. This will be left up to the discretion of the existing maintainers. - -## Process for becoming a maintainer - -Once the above criteria have been met, the sponsoring maintainer shall propose the addition of the new maintainer at a public Community Call. Existing maintainers shall vote at the next public Community Call whether the new maintainer should be added or not. Proxy votes may be submitted via email _before_ the meeting. A simple majority of the existing maintainers is required for the vote to pass. - -## Maintainer resignation - -While maintainers are expected in good faith to be committed to the project for a significant period of time, they are under no binding obligation to do so. Maintainers may resign at any time for any reason. If a maintainer wishes to resign they shall open a pull request to update the maintainers list removing themselves from the list. - -## Maintainer inactivity - -If a maintainer has remained inactive (not meeting the expectations of a maintainer) for a period of time (at least several months), an email should be sent to that maintainer noting their inactivity and asking if they still wish to be a maintainer. If they continue to be inactive after being notified via email, an existing maintainer may propose to remove the inactive maintainer at a public Community Call. Existing maintainers shall vote at the next public Community Call whether the inactive maintainer should be removed or not. Proxy votes may be submitted via email _before_ the meeting. A simple majority of the existing maintainers is required for the vote to pass. +For the full list of maintainers across all repos, the expectations of a maintainer and the process for becoming a maintainer, please see the [FireFly Maintainers page on the Hyperledger Wiki](https://wiki.hyperledger.org/display/FIR/Maintainers). From fc08fd076c3ff404d160fcadcba35e9b308fe35a Mon Sep 17 00:00:00 2001 From: Enrique Lacal Date: Wed, 17 Jul 2024 13:47:41 +0100 Subject: [PATCH 2/2] Update maintainer from Nicko to Enrique Signed-off-by: Enrique Lacal --- MAINTAINERS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS.md b/MAINTAINERS.md index 402d9f9..49100c7 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -8,7 +8,7 @@ The following is the list of current maintainers this repo: | Peter Broadhurst | peterbroadhurst | peter.broadhurst@kaleido.io | peterbroadhurst | | Andrew Richardson | awrichar | andrew.richardson@kaleido.io | Andrew.Richardson | | David Echelberger | eberger727 | david.echelberger@kaleido.io | dech727 | -| Nicko Guyer | nguyer | nicko.guyer@kaleido.io | nguyer | +| Enrique Lacal | enriquel8 | enrique.lacal@kaleido.io | enrique.lacal | This list is to be kept up to date as maintainers are added or removed.