Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native wrapper with changes for 0.4.0 release #216

Open
TimoGlastra opened this issue Sep 14, 2023 · 6 comments
Open

Update React Native wrapper with changes for 0.4.0 release #216

TimoGlastra opened this issue Sep 14, 2023 · 6 comments

Comments

@TimoGlastra
Copy link
Member

There's been some changes to the c-callable interface since the last release, mainly related to the support for did:indy.

Thse changes have been applied to Node.JS, but not React Native: f21a882

There may be other changes that are not in the Node.JS wrapper as well.

@TimoGlastra
Copy link
Member Author

Need a way to test the React Native app simply. @berendsliedrecht do you still have the test app?

@berendsliedrecht
Copy link
Contributor

Need a way to test the React Native app simply. @berendsliedrecht do you still have the test app?

I am working on fixing a bunch of project setup related issues in the anoncreds repository, which would make the example app easier. Might take some time though.

@genaris
Copy link
Contributor

genaris commented Sep 14, 2023

As discussed in AFJ WG call today, for the time being we'll update the React Native wrapper and release a dev version of the wrapper that can be tested in AFJ. Once we are confident with it, we can go for the official release.

@genaris
Copy link
Contributor

genaris commented Sep 18, 2023

I've started looking at it and already fixed React Native wrapper to match NodeJS in #218, but it seems that there are a few more things that weren't updated yet into JS wrappers:

  • indy_vdr_build_auth_rule_request
  • indy_vdr_build_auth_rules_request
  • indy_vdr_build_get_auth_rule_request
  • indy_vdr_build_get_frozen_ledgers_request
  • indy_vdr_build_ledgers_freeze_request
  • indy_vdr_build_node_request (it is only defined in nodejs wrapper's NativeBindings.ts)
  • indy_vdr_build_pool_config_request (it is only defined in nodejs wrapper's NativeBindings.ts)
  • indy_vdr_build_pool_restart_request
  • indy_vdr_build_pool_upgrade_request
  • indy_vdr_resolve
  • indy_vdr_dereference
  • indy_vdr_string_free

@TimoGlastra
Copy link
Member Author

"A few" 😅

@TimoGlastra
Copy link
Member Author

@genaris did you ever make a start at the other methods? Do you think we can release a new stable release without including these new features for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants