Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fold into hypertrace/kafka #7

Open
codefromthecrypt opened this issue Aug 24, 2020 · 2 comments
Open

Fold into hypertrace/kafka #7

codefromthecrypt opened this issue Aug 24, 2020 · 2 comments
Assignees
Labels

Comments

@codefromthecrypt
Copy link

While this is a separate helm feature vs management of the kafka broker, this is coupled to hypertrace/kafka directly.

For example, creating topics is a simple act, but one that could fail based on changes to https://github.com/hypertrace/kafka

Having this separate requires coordinated knowledge of this existing when updating hypertrace/kafka, and that also implies testing this when the former changes. For example, if you don't, the image layers aren't coherent and the operations could also fail without knowing. In other words, they are quite coupled and coupled things deserve to be in the same repo.

On the other hand, this couples changes to the changes in hypertrace/kafka. However, this repo changes infrequently so far. For example, last non-trivial changes were roughly once in 2 weeks. While there could be some tension versioning hypertrace/kafka due to this, the overall coherence and less things to track seems a higher win. Worst case, as separate tag version could be applied to the helm chart this represents.

Meanwhile, if folding in, the org namespace is also more coherent, and the perceived complexity is limited along with the maintenance advantages.

Since there's a historical tendency to use git submodules, I'll mention explicitly the goal is to remove repositories, not add yet another one. In other words, this repo will be removed or archived/attic'd.

Please vote thumbsup if you agree, or no action if you don't care. If you thumbs down, you must be able to express in objective terms what must be surmounted to progress this topic. eg words like "priority" aren't objective.

@jcchavezs
Copy link

I agree this could be in the same repo as hypertrace/kafka to reduce duplication of code for setup, CI and tests. I also don't see any drawback on moving this to the hypertrace/kafka repo as they might be usually used together (unless I am missing something). Unless the main propuse of this repo is to provide a general way to create topics (which I believe we don't want), it should not be a separated repo.

@jcchavezs
Copy link

Ping @laxmanchekka @kotharironak as they are going to investigate and move it into hypertrace/kafka or deprecate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants