Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimize] It is possible to optimise the logic used to load numerous contributor avatars. #938

Open
mingcheng opened this issue Jan 17, 2025 · 4 comments

Comments

@mingcheng
Copy link

Description

Depending on the circumstances, we load the avatars first and then display them when there are numerous contributors. The fact that not every user's avatar is shown simultaneously makes this incredibly wasteful.

For instance, the page https://github.com/exelban/stats/pulse is currently awaiting the loading of all contributors' avatars, which may take several minutes depending on the networking performance.

Image

Image

Consider displaying the avatar while loading it concurrently to speed up the loading process.

@wangyantong2000
Copy link
Collaborator

Yes, it does take a while now. Considering how to shorten the waiting time is a necessary thing for us.

@xiaoya-yaya
Copy link

I think users won't wait more than 5 seconds for the chart to render

@frank-zsy
Copy link
Contributor

I think we may not load all the avatars, we can load like top10 to top15 for every month, and the avatars of developers with low activity in the repo may not need to be rendered.

@wangyantong2000
Copy link
Collaborator

Afterwards, the proposed plan will be fully considered and combined. Minimize the number of contributor avatars that need to be loaded and the waiting time for loading as much as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants