Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism for disabling creating annotations and displaying highlights on the host frame for enable-annotations iframe use cases #6477

Open
jwgmeligmeyling opened this issue Jul 27, 2024 · 1 comment

Comments

@jwgmeligmeyling
Copy link

jwgmeligmeyling commented Jul 27, 2024

Whenever the VitalSourceInjector injector is used, a Guest is not instantiated in the Host window. As a result, annotating is only possible in the VitalSource viewer even though Hypothesis is loaded in the parent frame as well.

Whenever the HypothesisInjector is used, annotations are always enabled in the Host window. It seems there are valid use cases where this is simply not necessary, for example an LMS UI loading a reader type viewer in an iframe.

Perhaps a configuration property can be introduced that determines whether the Guest gets initialised?

@jwgmeligmeyling jwgmeligmeyling changed the title Mechanism of disabling annotations on the host frame for enable-annotations iframe use cases Mechanism for disabling creating annotations and displaying highlights on the host frame for enable-annotations iframe use cases Jul 27, 2024
@robertknight
Copy link
Member

Perhaps a configuration property can be introduced that determines whether the Guest gets initialised?

This makes sense. Maybe something like enableAnnotation: boolean to control whether annotation is enabled in the current frame?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants