Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cart: Streamline OrderPlaceEvent and remove EventPublisher interface #191

Open
jeinfeldt opened this issue Feb 10, 2020 · 0 comments
Open

cart: Streamline OrderPlaceEvent and remove EventPublisher interface #191

jeinfeldt opened this issue Feb 10, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jeinfeldt
Copy link
Contributor

Hello friends,

the handling of events has changed since this PR: 650f15f

The events ChangedQtyInCartEvent and AddToCartEvent have been adjusted
to match the event handling for deferred events of the ModifyBehaviour.

I would suggest the OrderPlacedEvent is also added as a deferred event in the placeOrder function of the CartService.

This has the side effect that we can remove the dependency to the interface EventPublisher as all events are dispatched by the EventRouter provided to the CartService.

I do not see the necessity for this interface, so it could be removed altogether, but feel free to correct me on this one.

Grazie!
@jeinfeldt jeinfeldt added enhancement New feature or request good first issue Good for newcomers labels Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeinfeldt