sorting on Publishers page is missing #12
Comments
danstoner
changed the title
danstoner
changed the title
|
Some possible solutions: |
|
It appears that despite the following commit to include a more recent version of jquery (3.3.x), we are still loading v2.2.4. Perhaps we are loading two versions (that is hint of previous post). Or is the production portal not actually deployed including that commit? Screenshot with some info...
|
|
I'll find some alternative sorting library as this one is not longer
supported.
Chris
…On Wed, May 29, 2019, 9:56 PM Dan Stoner ***@***.***> wrote:
It appears that despite this commit to include a more recent version of
jquery, we are still loading v2.2.4.
0f3f7d9
<0f3f7d9>
Perhaps we are loading two versions. Or is production portal not actually
deployed including that commit?
Screenshot with some infos.
[image: Screenshot from 2019-05-29 21-48-48]
<https://user-images.githubusercontent.com/2325459/58602885-86b32400-825c-11e9-9f96-796d1d6361df.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ACLZ2U6RXH7GIQLYP6MSBDDPX4X4TA5CNFSM4HM65SR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWRDZKI#issuecomment-497171625>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACLZ2UZT3Q5PM6KOX6XQE5TPX4X4TANCNFSM4HM65SRQ>
.
|
|
The following looks like a maintained fork but I have not figured out how to integrate it properly into the... complex... javascript environment we are running. https://github.com/Mottie/tablesorter During my struggle, I have seen a number of recommendations against using jQuery in React apps since they both manipulate the DOM. One solution might be to refactor the publishers page to use native React component / react-bootstrap-table / react-bootstrap-table-next https://react-bootstrap-table.github.io/react-bootstrap-table2/ |
|
What. the. bloody. hell. Earlier in the week... Didn't work. Didn't work. Didn't work. Tried a dozen things. Didn't work. Tonight when I fired things up I have table sorting on the publishers page (locally). I cloned a fresh copy of master branch again tonight and sorting just works with no apparent code changes. So at least here is screenshot of what publishers page looks like with table sorting on columns...
And then it stopped working again! So perhaps it all has to do with the order that modules are getting loaded, and occasionally they load in an order that is favorable to tablesorter. |
|
I have a case where running locally from one directory provides sorting (and no console error about The git checkouts are identical. There are a good many differences located in the git ignored directories. This hints at a problem with the build process. It will take me a while to go thru the diff. |
|
Mind you I was futzing around with some of those ignored dirs manually. |
|
In the "working" version: |
|
Starting with a working idb-portal...
|
|
Run
diff:
|
|
yarn.install.verbose.log |
|
It's like a Gordian knot made with Yarn.
…On Sun, Jun 9, 2019 at 4:33 PM Dan Stoner ***@***.***> wrote:
yarn.install.verbose.log
<https://github.com/iDigBio/idb-portal/files/3269933/yarn.install.verbose.log>
attached verbose capture of yarn install --verbose during transition of
"sorting works" to "sorting stops working, tablesorter issue"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ACLZ2U44LRDFDG7NWVH437LPZVSKVA5CNFSM4HM65SR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIRTLI#issuecomment-500242861>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACLZ2UYSOBAGUYXOFUFIXJ3PZVSKVANCNFSM4HM65SRQ>
.
|
|
As you know, the tablesorter plugin is compatible with jQuery 3.x. I have a
working page using tablesorter here:
https://codepen.io/wilsotc/pen/jjOXMR
I have confirmed that tablesorter is being loaded via require before the
error handler that calls the tablesorter function. The tablesorter library
is being assigned to window.tablesorter and it doesn't look like it's ever
attaching itself to jQuery. Strange that it works some of the time.
Chris
…On Tue, Jun 11, 2019 at 6:55 AM Chris Wilson ***@***.***> wrote:
It's like a Gordian knot made with Yarn.
On Sun, Jun 9, 2019 at 4:33 PM Dan Stoner ***@***.***>
wrote:
> yarn.install.verbose.log
> <https://github.com/iDigBio/idb-portal/files/3269933/yarn.install.verbose.log>
> attached verbose capture of yarn install --verbose during transition of
> "sorting works" to "sorting stops working, tablesorter issue"
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <#12?email_source=notifications&email_token=ACLZ2U44LRDFDG7NWVH437LPZVSKVA5CNFSM4HM65SR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIRTLI#issuecomment-500242861>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/ACLZ2UYSOBAGUYXOFUFIXJ3PZVSKVANCNFSM4HM65SRQ>
> .
>
|
|
Did this ever make it into the production code? It seems to still be a problem. |
|
The portal javascript call stack is so polluted I have been unable to find the source of this issue. |
|
Chris wrote in internal Slack channel:
Moving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
regarding https://www.idigbio.org/portal/publishers
The lists in each section used to be sortable by clicking on each column heading. The little up/down arrow indicators for sort are not visible and clicking in the column header does not seem to do anything.
My Chrome dev console contains:
Uncaught TypeError: $(...).tablesorter is not a functionThe text was updated successfully, but these errors were encountered: