Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download API doesn't receive email address if no text entered in search boxes #16

Open
nrejac opened this issue Jan 15, 2020 · 4 comments
Assignees
Labels

Comments

@nrejac
Copy link
Contributor

nrejac commented Jan 15, 2020

An email address entered by users who are using the portal to download records may not be passed through if the user does not enter text in the search boxes. The outcome is that users are not notified when their downloads are complete and repeatedly submit identical jobs.

Steps to reproduce:

  1. go to http://portal.idigbio.org/portal/search
  2. Click "Must have media" checkbox
  3. Click Download tab
  4. Enter email address in Email box
  5. Click download button
  6. Check Celery Flower task interface. Task will appear but email address does not appear in args box as expected.

I suspect the address is not getting passed to the Download API for some reason.

@wilsotc
Copy link
Contributor

wilsotc commented Mar 19, 2020

It looks like this code hasn't changed since 2015 and that it won't submit the download request from the portal unless there's an email value. The idb-backend project houses that controller and it passes it to a redis server. Is it possible that a redis server didn't get powered back on after the shutdown?

@roncanepa
Copy link
Contributor

From the work I did a while ago to track things down, redis-10 is the one that powers search stuff and has been online. All searches would be failing if this machine wasn't on.

@wilsotc
Copy link
Contributor

wilsotc commented Mar 19, 2020

Then this should be moved to an idb-backend bug. I've been unable to reproduce a condition within the portal that doesn't populate the email address and unless that address is populated with something valid or not, the portal won't submit the download request.
Following the exact reproduction steps above, this is the content sent to the download controller:
google chrome:
rq: {"hasImage":true}
email: [email protected]
firefox:
{"Form data":{"rq":"{"hasImage":true}","email":"[email protected]"}}

@nrejac
Copy link
Contributor Author

nrejac commented Mar 19, 2020

Sounds good, thanks for looking at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants