Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: helm: Fix Helm repo installation and refresh #37

Closed
pozgo opened this issue Jan 6, 2021 · 2 comments · Fixed by #45
Closed

cluster: helm: Fix Helm repo installation and refresh #37

pozgo opened this issue Jan 6, 2021 · 2 comments · Fixed by #45
Assignees

Comments

@pozgo
Copy link
Member

pozgo commented Jan 6, 2021

No description provided.

@pozgo pozgo self-assigned this Jan 6, 2021
@pozgo
Copy link
Member Author

pozgo commented Jan 8, 2021

Make sure wait 10s is moved to helm function instead of main func

log.Println("Waiting 10 seconds for cluster to stabilize before taking next steps\n")

@dfernandezm
Copy link
Collaborator

Also, no need to use install-helm.sh and the surrounding setup. Originally this was setup with Helm 2. The syntax to install/upgrade is different too. Already tracking upgrade through SDK in #26 , but can consider just a minor commandline change.

About that 10s wait, some time is needed after the cluster is up (terraform apply finishes) and actioning it (install helm). With v3 this goes away.

Proposal:

  • Refactor helmDeployer / helm.go / deploy.go so it works with Helm v3 (need issue created) - estimate 1 day for it to work with v3
  • Future inclusion of wrapper which removes the need for the helm binary (Use helm wrapper  #26) - need investigation for assessing estimate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants