Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up and login issues #12

Open
tschaffter opened this issue Nov 11, 2014 · 2 comments
Open

Sign up and login issues #12

tschaffter opened this issue Nov 11, 2014 · 2 comments

Comments

@tschaffter
Copy link

  1. When signing up, the fields "Password" and "Confirm Password" are set to two different values.

Result: Form is accepted and redirection to Dashboard, console message:
GET http://localhost:8080/oauth2-provider/v1.0/me 401 (Unauthorized) jquery-1.8.2.min.js:2

Expected: a message saying that the two passwords don't match

  1. Idem when signing up with "Password" and "Confirm Password" set to the SAME value (e.g. "password")

Result: Form is accepted and redirection to Dashboard, console message:
GET http://localhost:8080/oauth2-provider/v1.0/me 401 (Unauthorized) jquery-1.8.2.min.js:2

  1. Logout after signing up, then login is impossible with correct credentials

Result: Message "Email and/or password did not match a user account."
POST http://localhost:8080/oauth2-provider/oauth/token 400 (Bad Request) jquery-1.8.2.min.js:2

UPDATE: I numbered the points from 1. to 3. but they all appear as 1.

@iainporter
Copy link
Owner

Sorry,
Been busy today so only just had a chance to look at this.
The problem was in the javascript that I changed to handle my json payload experiment.
I have reverted the commit and it should be good now.

@tschaffter
Copy link
Author

Login is ok but entering two different passwords during signing up is still silently accepted.

A unit test using Karma or even an end-to-end test using Protector could prevent committing broken login interface. I may even write it myself, in which case I'll share the code with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants